Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message #435

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Fix error message #435

merged 2 commits into from
Jul 16, 2024

Conversation

Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Jul 16, 2024

Fixes #434


This change is Reviewable

@Enkidu93 Enkidu93 requested a review from johnml1135 July 16, 2024 18:34
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.73%. Comparing base (54f5b47) to head (16199af).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #435   +/-   ##
=======================================
  Coverage   61.73%   61.73%           
=======================================
  Files         232      232           
  Lines       11825    11825           
  Branches     1510     1510           
=======================================
  Hits         7300     7300           
  Misses       3998     3998           
  Partials      527      527           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

@johnml1135
Copy link
Collaborator

:lgtm:

@johnml1135 johnml1135 merged commit 810b010 into main Jul 16, 2024
2 checks passed
@johnml1135 johnml1135 deleted the bad_error_message branch July 16, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading error message when handling unknown languages
3 participants